Maryhipp/trigger phrases #5825
Closed
Maryhipp/trigger phrases #5825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryhipp
requested review from
psychedelicious,
blessedcoolant,
hipsterusername,
lstein,
GreggHelt2,
brandonrising and
RyanJDick
as code owners
github-actions
bot
added
api
python
added 2 commits
February 28, 2024 11:49
| @@ -164,6 +164,7 @@ def _from_model_json(self, model_json: Dict[str, Any], version_id: Optional[int] | |||
| AllowDerivatives=model_json["allowDerivatives"], | |||
| AllowDifferentLicense=model_json["allowDifferentLicense"], | |||
| ), | |||
| trigger_phrases=version_json["trainedWords"], | |||
There was a problem hiding this comment.
This is already on the metadata object as trained_words
There was a problem hiding this comment.
Yeah I was trying to not use the civit key just to spite them
There was a problem hiding this comment.
I mean the metadata schema already extracts it a few lines earlier
There was a problem hiding this comment.
Do you prefer trained_words? I don't feel strongly
There was a problem hiding this comment.
trigger_phrases works for me, and is more consistent with the terminology we use for textual inversion embeddings.
10 tasks
lstein
reviewed
Mar 1, 2024
| @@ -164,6 +164,7 @@ def _from_model_json(self, model_json: Dict[str, Any], version_id: Optional[int] | |||
| AllowDerivatives=model_json["allowDerivatives"], | |||
| AllowDifferentLicense=model_json["allowDifferentLicense"], | |||
| ), | |||
| trigger_phrases=version_json["trainedWords"], | |||
There was a problem hiding this comment.
trigger_phrases works for me, and is more consistent with the terminology we use for textual inversion embeddings.
lstein
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Description
QA Instructions, Screenshots, Recordings
Merge Plan
Added/updated tests?
have not been included
[optional] Are there any post deployment tasks we need to perform?