Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hang on model manager install unit tests #5835

Merged

Conversation

lstein
Copy link
Collaborator

@lstein lstein commented Feb 29, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because:

Have you updated all relevant documentation?

  • Yes
  • No

Description

This PR fixes the periodic hang and timeout that occurs during the test_model_install and test_download unit tests. It also changes the default timeouts for unit tests (1 minute rather than 5 hours) and fixes the handling of the invokeai root during pytest.

Finally, it removes redundant and slow hashing calls executed during the model install process.

Related Tickets & Documents

See discord thread: https://discord.com/channels/1020123559063990373/1212521379593719918/1212521450393829417

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Use git actions to run test_invoke.py pip repeatedly. There should no longer be intermittent hangs and timeouts.

Merge Plan

Merge after review.

Added/updated tests?

  • Yes
  • No : please replace this line with details on why tests
    have not been included

[optional] Are there any post deployment tasks we need to perform?

@github-actions github-actions bot added python PRs that change python files Root PythonDeps services PRs that change app services labels Feb 29, 2024
@github-actions github-actions bot added the backend PRs that change backend files label Feb 29, 2024
@psychedelicious psychedelicious changed the base branch from next to psyche/chore/rebase-next-on-main February 29, 2024 23:20
@psychedelicious
Copy link
Collaborator

I've rebased this on my rebased next branch, so we can merge that and get all tests passing on the rebased next branch.

@psychedelicious psychedelicious merged commit d1d2433 into psyche/chore/rebase-next-on-main Feb 29, 2024
8 checks passed
@psychedelicious psychedelicious deleted the bugfix/download-hang branch February 29, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend PRs that change backend files python PRs that change python files Root services PRs that change app services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants