Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node to read watermarks #6630

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add node to read watermarks #6630

wants to merge 2 commits into from

Conversation

lstein
Copy link
Collaborator

@lstein lstein commented Jul 17, 2024

Summary

This adds an invocation to read the invisible watermark created by the AddWatermark invocation.

Related Issues / Discussions

QA Instructions

Screenshot from 2024-07-17 15-12-13

  1. Create a simple workflow which pipes an image from AddWatermark to RetrieveWatermark, as per example above
  2. [Optional] Change the default watermark text from "InvokeAI" to something of your choice. If you do this, be sure to adjust the watermark string length in RetrieveWatermark appropriately.
  3. Run the invocation. The output from RetrieveWatermark should match the AddWatermark string.

Merge Plan

Merge when approved.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added python PRs that change python files invocations PRs that change invocations backend PRs that change backend files labels Jul 17, 2024
@hipsterusername
Copy link
Member

Is the current watermarking mode what we want to commit to long term? Seems like it makes a notable impact on images; although, I’m not sure there’s a better one that’s open source. I know Meta had one, but they put a dumb license on it.

@lstein
Copy link
Collaborator Author

lstein commented Jul 20, 2024

Is the current watermarking mode what we want to commit to long term? Seems like it makes a notable impact on images; although, I’m not sure there’s a better one that’s open source. I know Meta had one, but they put a dumb license on it.

Here's another library which seems to be based on the same algorithms as invisible-watermark: https://github.com/guofei9987/blind_watermark . It lets you embed either a watermark text or an image in the file. I can play around with it and see if the image effects are less noticeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend PRs that change backend files invocations PRs that change invocations python PRs that change python files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants