feat(nodes): skip on duplicate loras instead of erroring #6685
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
LoRA
andSDXL LoRA
nodes would error if it duplicated LoRAs. To make the nodes more resilient, they now skip dupes and log a warning to the console instead.Also added a warning for the LoRA Collection Loader nodes. These already skipped but didn't log a warning.
Related Issues / Discussions
https://discord.com/channels/1020123559063990373/1130288930319761428/1266235074647691335
QA Instructions
This workflow has 4 test flows, each with 3 LoRA loaders:
For each flow, set two of the loaders to the same LoRA and the 3rd to a different. The output for each flow should have only two LoRAs, and you should have warnings in the console for each.
If you test this on main, we expect errors for both the chain flows.
lora test(1).json
Merge Plan
n/a
Checklist