build: remove broken scripts #6783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two scripts are broken and can cause data loss. Remove them. They are not in the launcher script, but _are_ available to users in the terminal/file browser. Hopefully, when we removing them here, `pip` will delete them on next installation of the package...
psychedelicious
requested review from
blessedcoolant,
hipsterusername and
lstein
as code owners
hipsterusername
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These two scripts are broken and can cause data loss. Remove them.
They are not in the launcher script, but are available to users in the terminal/file browser.
Hopefully, when we removing them here,
pipwill delete them on next installation of the package...Related Issues / Discussions
QA Instructions
Whether this deletes the scripts on users' machines or not doesn't matter - this change is needed either way.
Merge Plan
n/a
Checklist