-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FLUX image-to-image and inpainting #6798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only consideration here is inconsistency between name of VAE between flux and SD nodes. I think the simpler name is probably the best top level name, but it should be discoverable under encode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will approve in case the desire is to address this later
invokeai/app/services/workflow_records/default_workflows/FLUX Image to Image.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that comment lgtm! It's somewhat tangential to the work here so it could be updated in a separate PR
… or without a channel dimension.
…mage-to-image in the FLUX denoising node. Previously we were using the denoising_start value, but in some cases with an inpaintin mask you may want to run image-to-image from densoising_start=0.
…/'FLUX Latents to Image'
27039be
to
627b0bf
Compare
Renamed 'FLUX VAE Encode'/'FLUX VAE Decode' to 'FLUX Image to Latents'/'FLUX Latents to Image' in b43da46 |
Summary
This PR adds support for Image-to-Image and inpainting workflows with the FLUX model.
Full changelog:
FLUX VAE Encode
andFLUX VAE Decode
nodesFLUX Text-to-Image
node toFLUX Denoise
(since it now supports image-to-image too). This is a workflow-breaking change.Latents
param on the FLUX denoising node.Denoise Mask
param on the FLUX denoising node.Example
FLUX inpainting workflow
Input image
Mask
Output image
Callouts for reviewers:
FLUX VAE Encode
andFLUX VAE Decode
nodes. Alternatively, I could have tried to match these names to the corresponding SD nodes (e.g.FLUX Image to Latents
,FLUX Latents to Image
). Personally, I prefer the current names, but want to hear other opinions.Usage notes:
denoise_start
(e.g. 0.03) to start denoising on step ~1-4 out of ~30.FLUX Denoise
node, so thedenoise_end
parameter has limited utility. This will be added in the future.QA Instructions
Test the following workflows:
Merge Plan
No special instructions.
Checklist