Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix, feat: canvas followups 2 #6821

Merged
merged 19 commits into from
Sep 8, 2024
Merged

Commits on Sep 7, 2024

  1. Configuration menu
    Copy the full SHA
    3963cc3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    54e7f48 View commit details
    Browse the repository at this point in the history
  3. feat(ui): reset $shouldShowStagedImage when start staging

    Realized we can use listener middleware to respond to _actions_, as opposed to using the redux store subscription to respond to _state changes_... This might simplify some things.
    
    Using this pattern here.
    
    Only hiccup - there's a TS issue preventing this from being added to the state api module. The `addListener` method has an overloaded type signature and TS cannot extract the overloaded arg type using `Parameters<T>`. As a result, if we try to wrap this, we end up with a broken TS signature for the wrapper method.
    psychedelicious committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    2c7bed7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    50778e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. Configuration menu
    Copy the full SHA
    c77a268 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f86f089 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    32ff074 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cb40edf View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    df1eb1a View commit details
    Browse the repository at this point in the history
  6. chore(ui): lint

    psychedelicious committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    b5006ff View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3d86fa6 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    910c685 View commit details
    Browse the repository at this point in the history
  9. feat(ui): snap to grid

    Snap can be any of off, 8px or 64px.
    
    The snap is used when moving and transforming entities.
    
    When transforming and locking aspect ratio, the snap is ignored entirely, because we'd change the aspect ratio if we forced the snap.
    
    Otherwise, if we are not locking aspect ratio (e.g. the user is holding shift), we snap the transform anchors to the grid.
    psychedelicious committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    ebb3747 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    13974ef View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    db30014 View commit details
    Browse the repository at this point in the history
  12. chore(ui): lint

    psychedelicious committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    0d3ad32 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    fe1a465 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    54bd5b4 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    6f06ca8 View commit details
    Browse the repository at this point in the history