Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): spandrel filter #6844

Merged
merged 3 commits into from
Sep 12, 2024
Merged

fix(ui): spandrel filter #6844

merged 3 commits into from
Sep 12, 2024

Conversation

psychedelicious
Copy link
Collaborator

Summary

  • Fix: infinite recursion (i.e. a crash) when selecting spandrel filter w/ no spandrel models installed
  • Fix: translations for spandrel filter

Related Issues / Discussions

Closes #6835

QA Instructions

Spandrel (image-to-image) filter shouldn't crash when you have no spandrel models installed.

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added the frontend PRs that change frontend files label Sep 12, 2024
@psychedelicious psychedelicious enabled auto-merge (rebase) September 12, 2024 21:22
@psychedelicious psychedelicious merged commit a802b92 into main Sep 12, 2024
14 checks passed
@psychedelicious psychedelicious deleted the psyche/fix/spandrel-filter branch September 12, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryhipp maryhipp maryhipp approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
2 participants
@psychedelicious @maryhipp