Invert the expected denoise_mask parameter to the FLUX Denoise node
#6853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o match the behaviour of Denoise Latents node used for SD.
RyanJDick
requested review from
blessedcoolant,
psychedelicious,
brandonrising and
hipsterusername
as code owners
github-actions
bot
added
python
hipsterusername
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invert the expected
denoise_maskparameter to the FLUX Denoise node to match the behaviour of Denoise Latents node used for SD.Summary
Changes the definition of the denoise_mask parameter on the "FLUX Denoise" node to match the "Denoise Latents" node. New definition: "Values of 0.0 represent the regions to be fully denoised, and 1.0 represent the regions to be preserved."
Also updates the docs in a few places to make this expectation more clear.
QA Instructions
I tested on top of this branch: #6846
Checklist