feat(ui): tablet support #7008
Merged
feat(ui): tablet support #7008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets touch input and tablet input working for basic drawing functions.
- Move color picker to floating buttons - Always show floating buttons - Minor layout tweaks for floating buttons
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
github-actions
bot
added
frontend-deps
psychedelicious
temporarily deployed
to
testpypi
GitHub Actions
Inactive
hipsterusername
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tablet support involves a number of changes:
perfect-freehandto compute a polygon that represents a brush stroke with variable pressure.I've also bumped the version to v5.1.0rc1 in this PR so I can do an RC release.
Related Issues / Discussions
QA Instructions
I've tested extensively on an iPad w/ apple pencil, and using an iPad as a tablet input device via Astropad. This forwards pen and touch inputs from the iPad to the host computer, emulating those input devices. For the most part, it works exactly like a drawing tablet.
Test Matrix
Input devices:
Tools:
Known Issue
On Safari, the color picker doesn't work in some situations due to a tainted canvas issue. For example, if there is an inpaint mask layer, it doesn't work. This issue isn't new - it also occurs on the current stable release.
Unfortunately, because all iOS browsers are secretly safari under the hood, this means the color picker often doesn't work on iPad.
Merge Plan
n/a
Checklist