Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): recall LoRAs may create duplicates #7016

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix(ui): recall LoRAs may create duplicates #7016

merged 1 commit into from
Oct 3, 2024

Conversation

psychedelicious
Copy link
Collaborator

Summary

fix(ui): recall LoRAs may create duplicates

Related Issues / Discussions

Closes #7004

QA Instructions

  • Generate w/ a LoRA
  • Change the weight of the LoRA so when you recall, you know it replaced the existing LoRA
  • Recall that LoRA from the image you just generated
  • It should replace the existing LoRA and not duplicate it

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added the frontend PRs that change frontend files label Oct 3, 2024
@hipsterusername hipsterusername enabled auto-merge (rebase) October 3, 2024 12:33
@hipsterusername hipsterusername force-pushed the psyche/fix/ui/recall-lora-duplicate branch from 4aeb7cf to e1acb54 Compare October 3, 2024 12:33
@hipsterusername hipsterusername force-pushed the psyche/fix/ui/recall-lora-duplicate branch from e1acb54 to b0faaa6 Compare October 3, 2024 12:48
@hipsterusername hipsterusername merged commit 80d7d69 into main Oct 3, 2024
14 checks passed
@hipsterusername hipsterusername deleted the psyche/fix/ui/recall-lora-duplicate branch October 3, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: [5.0.2] Recall LoRA causes duplicate LoRA entries
2 participants
@psychedelicious @hipsterusername