fix(mm): model names with periods may install to wrong location #7117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we provide a config object during a model install, the config can override individual fields that would otherwise be derived programmatically. We use this to install starter models w/ a given name, description, etc. This logic used `pathlib` to append a suffix to the model's name. When we provide a model name that has a period in it, `pathlib` splits the name at the period and replaces everything after it with the suffix. This is then used to determine the output path of the model. As a result, some starter model paths are incorrect. For example, `IP Adapter SD1.5 Image Encoder` gets installed to `sd-1/clip_vision/IP Adapter SD1`.
psychedelicious
requested review from
blessedcoolant,
brandonrising and
hipsterusername
as code owners
github-actions
bot
added
python
maryhipp
approved these changes
Oct 15, 2024
psychedelicious
changed the title
hipsterusername
approved these changes
Oct 15, 2024
|
Is there a reason the file name needs to match the model name? If it's just to more easily find the model while looking through the model directory, I'd almost rather just use the model key as the filename. I can't find a specific model name that breaks with this implementation, but it definitely introduces the possibility of saving a file with an unintended file extension that some OS out there doesn't like 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we provide a config object during a model install, the config can override individual fields that would otherwise be derived programmatically. We use this to install starter models w/ a given name, description, etc.
This logic used
pathlibto append a suffix to the model's name. When we provide a model name that has a period in it,pathlibsplits the name at the period and replaces everything after it with the suffix. This is then used to determine the output path of the model.As a result, some starter model paths are incorrect. For example,
IP Adapter SD1.5 Image Encodergets installed tosd-1/clip_vision/IP Adapter SD1.Related Issues / Discussions
n/a
QA Instructions
Delete the SD1.5 IP Adapter and its CLIP vision model. Reinstall them. Should work fine. I don't think there will be any other effects from this change but probably good to get a review from @lstein and @brandonrising .
Merge Plan
n/a
Checklist