refactor(ui): logging config handling #7143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
psychedelicious
force-pushed
the
psyche/refactor/ui/logging
branch
from
9833063
to
9f9f82a
Compare
hipsterusername
approved these changes
Oct 18, 2024
Introduce two-stage logging configuration and overrides for enabled status, log level and log namespaces. The first stage in `<InvokeAIUI />`, before we set up redux (and therefore before we have access to the user's configured logging setup). In this stage, we use the overrides or default values. The second stage is in `<App />`, after we set up redux, via `useSyncLoggingConfig`. In this stage, we use the overrides or the user's configured logging setup. This hook also handles pushing changes made by the user into localstorage. Other changes: - Extract logging config to util function - Remove the `useEffect` from `SettingsModal` that was changing the logging settings - Remove extraneous log effects from `useLogger` - Export new `LoggingOverrides` type
psychedelicious
force-pushed
the
psyche/refactor/ui/logging
branch
from
7aca864
to
a13e7cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce two-stage logging configuration and overrides for enabled status, log level and log namespaces.
The first stage in
<InvokeAIUI />, before we set up redux (and therefore before we have access to the user's configured logging setup). In this stage, we use the overrides or default values.The second stage is in
<App />, after we set up redux, viauseSyncLoggingConfig. In this stage, we use the overrides or the user's configured logging setup. This hook also handles pushing changes made by the user into localstorage.Other changes:
useEffectfromSettingsModalthat was changing the logging settingsuseLoggerRelated Issues / Discussions
n/a
QA Instructions
Should be no difference in behaviour:
debuglogs at startup about rehydrationMerge Plan
n/a
Checklist