Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xformers before installation #7161

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

ebr
Copy link
Member

@ebr ebr commented Oct 22, 2024

Summary

Try to remove xformers before installing or upgrading Invoke. This fixes the issue for users of newer GPUs where a lingering xformers installation would break torch compatibility.

If xformers is still needed (older GPU / option 2 selected for install), it will simply be reinstalled.

Related Issues / Discussions

Closes #7142

QA Instructions

  1. Make a fresh install selecting InvokeAI v5.0.0 and Option 2 in the installer (CUDA+xFormers)
  2. After the installation completes, activate the virtual environment and confirm that xformers is installed: pip freeze | grep xformers should return xformers==0.0.25.post1
  3. Upgrade the same install to the latest release using Option 1 in the installer (no xFormers)
  4. Check the virtual environment once again and confirm that xformers is no longer present (there should be no output from pip freeze | grep xformers
  5. Run the application to confirm that it launches and works.

Merge Plan

Merge at will

Checklist

  • The PR has a short but descriptive title, suitable for a changelog

@github-actions github-actions bot added the installer PRs that change the installer label Oct 22, 2024
@ebr ebr requested a review from psychedelicious October 22, 2024 18:29
@psychedelicious psychedelicious merged commit 62919a4 into main Oct 22, 2024
14 checks passed
@psychedelicious psychedelicious deleted the ebr/installer-rm-xformers branch October 22, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installer PRs that change the installer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: xformers not uninstalled when using new installer option that excludes xformers
3 participants