fix(nodes): relaxed validation for segment anything #7253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
brandonrising and
hipsterusername
as code owners
github-actions
bot
added
python
hipsterusername
approved these changes
Nov 4, 2024
The validation on this node causes graph validation to valid. It must be validated _after_ instantiation. Also, it was a bit too strict. The only case we explicitly do not handle is when both bboxes and points are provided. It's acceptable if neither are provided. Closes #7248
hipsterusername
force-pushed
the
psyche/fix/nodes/segment-anything-validation
branch
from
a842e5a to
e4022e5
Compare
hipsterusername
deleted the
psyche/fix/nodes/segment-anything-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The validation on this node causes graph validation to valid. It must be validated after instantiation.
Also, it was a bit too strict. The only case we explicitly do not handle is when both bboxes and points are provided. It's acceptable if neither are provided.
Related Issues / Discussions
Closes #7248
QA Instructions
Merge Plan
n/a
Checklist