Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): simplify parameter schema declaration #7281

Merged

Conversation

rikublock
Copy link
Contributor

Summary

  • Simplify parameter schema declaration.
  • Export some unused zParameter variables.
  • Exclude the schema file in invokeai/frontend/web/knip.ts.

I prefer this concise version as it’s the most readable. In my opinion, more selective exports add unnecessary verbosity again.

Related Issues / Discussions

#7217 (comment)

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added the frontend PRs that change frontend files label Nov 6, 2024
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks

@psychedelicious psychedelicious merged commit bb0a630 into invoke-ai:main Nov 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants