Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Look in known subfolders for configs for clip variants #7283

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

brandonrising
Copy link
Collaborator

Summary

Currently if a text encoder is in a subfolder of a climpembed, we have no way of determining its variant. This enables our probe to search deeper than the root directory.

QA Instructions

Install InvokeAI/clip-vit-large-patch14-text-encoder::bfloat16 and validate it checks the text_encoder via debugger

Merge Plan

Can be merged when approved

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added python PRs that change python files backend PRs that change backend files labels Nov 6, 2024
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with both directly instsalling the CLIP text encoder and installing a FLUX schnell dev, which installs the CLIP text encoder as a dependency.

@psychedelicious psychedelicious mentioned this pull request Nov 7, 2024
2 tasks
@psychedelicious psychedelicious enabled auto-merge (rebase) November 7, 2024 00:53
@psychedelicious psychedelicious merged commit c064257 into main Nov 7, 2024
14 checks passed
@psychedelicious psychedelicious deleted the brandon/subfolder-clip-variants branch November 7, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend PRs that change backend files python PRs that change python files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants