fix(ui): fit bbox to layers math #7297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
psychedelicious
force-pushed
the
psyche/fix/ui/fit-bbox-to-layers-math
branch
from
d532956
to
2ef07c6
Compare
hipsterusername
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The math used to fit the bbox to layers was a bit off and could result in a bbox that was slightly too large.
Related Issues / Discussions
Issue that prompted me to review the logic: https://discord.com/channels/1020123559063990373/1020123559831539744/1304232644338384927
QA Instructions
The fit bbox to layers button should always result in the bbox being the same size as the composite of all raster layers, or smaller. The issue affects layers whose size is not already a multiple of the grid size (8px or 16px depending on model).
This image triggers the issue when it is the only layer - could test with it.
Checklist