-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(ui): reverse queue list #8488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): reverse queue list #8488
Conversation
3f0c3b8 to
10e1b09
Compare
|
Some comments on the PR:
|
invokeai/frontend/web/src/features/queue/components/QueueList/QueueItemComponent.tsx
Show resolved
Hide resolved
invokeai/frontend/web/src/features/queue/components/QueueList/QueueList.tsx
Outdated
Show resolved
Hide resolved
invokeai/frontend/web/src/features/queue/components/QueueList/QueueList.tsx
Outdated
Show resolved
Hide resolved
invokeai/frontend/web/src/features/queue/components/QueueList/QueueList.tsx
Outdated
Show resolved
Hide resolved
invokeai/frontend/web/src/features/queue/components/QueueList/types.ts
Outdated
Show resolved
Hide resolved
invokeai/frontend/web/src/features/queue/components/QueueList/QueueItemComponent.tsx
Show resolved
Hide resolved
1732c30 to
c670aa7
Compare
|
@psychedelicious, I expect now |
|
There are issues with sorting on the
|
c670aa7 to
1244e5a
Compare
Ah, dang. We could fix the sorting such that we sort by the meaning of the status (i.e. pending, in progress, completed, failed, canceled) but the invalidation aspect is tricky. Let's make that column not sortable for now. |
@psychedelicious, how about |
I believe |
How about |
It looks like the whole slice can go now! The only other two things in it are |
1244e5a to
7287197
Compare
|
|
b712864 to
618e2aa
Compare
psychedelicious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks!
70e124d to
d2dab99
Compare
…QueueItemComponent.tsx Co-authored-by: psychedelicious <4822129+psychedelicious@users.noreply.github.com>
…QueueList.tsx Co-authored-by: psychedelicious <4822129+psychedelicious@users.noreply.github.com>
…QueueList.tsx Co-authored-by: psychedelicious <4822129+psychedelicious@users.noreply.github.com>
makes it a bit less sluggish
d2dab99 to
771d316
Compare
Summary
A new feature was implemented to reverse queue list and virtualize the queue list
QUEUE_ORDER_BY, was created insession_queue_common.pyto represent allowed sort columnsget_queue_itemIds, was created inSessionQueueBasefor acquiring all queue item IDsget_queue_itemIds, was created inSqliteSessionQueuefor acquiring all queue item IDsget_queue_item_idsandget_queue_items_by_item_ids, were created insession_queue_routerto expose the functionality of acquiring all queue item IDs and getting queue items by item IDsQueueItemComponentchanges:completedAtfield was added, whilebatchFieldValuesfield was removed to adhere to new requirementsQueueItemPlaceholdercomponent was added to provide a placeholder icon while the queue item is being loadedQueueListcomponent was refactored to virtualize item loadingQueueListHeaderColumncomponent was created to encapsulate sort related logic and componentsQueueListHeadercomponent was refactored to useQueueListHeaderColumncomponentsuseQueueItemIds,useScrollableQueueListanduseRangeBasedQueueItemFetching, were created to virtualize the queue listsortByandsortOrder, were added to queueSlice.ts to represent and persist sort related datagetQueueItemIdsandgetQueueItemDTOsByItemIds, were added to queue.ts to expose virtualization related API endpointsschema.tswas generated to include new virtualization related endpointsqueue.completedAt,queue.sortColumn,queue.sortBy,queue.sortOrderAscendingandqueue.sortOrderDescending, were added toen.jsonRelated Issues / Discussions
Closes #1234" format, so that the issue will be automatically closed when the PR merges.-->
Checklist
What's Newcopy (if doing a release after this PR)