fix(ui): 🐛 HotkeysModal and SettingsModal initial focus
#8687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of using the `initialFocusRef` prop, the `Modal` component was focusing on the last available Button. This is a workaround that uses `tabIndex` instead which seems to be working. Closes invoke-ai#8685
lstein
approved these changes
Dec 22, 2025
Collaborator
lstein
left a comment
lstein
left a comment
There was a problem hiding this comment.
Tested. When the modal is first displayed the focus is assigned to the Search History input field, as expected. No code issues identified.
joshistoast
added a commit
to joshistoast/InvokeAI
that referenced
this pull request
Dec 23, 2025
…i#8687) * fix(ui): 🐛 `HotkeysModal` and `SettingsModal` initial focus instead of using the `initialFocusRef` prop, the `Modal` component was focusing on the last available Button. This is a workaround that uses `tabIndex` instead which seems to be working. Closes invoke-ai#8685 * style: 🚨 satisfy linter --------- Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of using the
initialFocusRefprop, theModalcomponent was focusing on the last available Button. This is a workaround that usestabIndexinstead which seems to be working.Related Issues / Discussions
Closes #8685
QA Instructions
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)