Upgrade and adapt to the new GOBL Extensions feature #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavalle
changed the title
cavalle
commented
Aug 29, 2023
| @@ -0,0 +1,59 @@ | |||
| package fatturapa_test | |||
There was a problem hiding this comment.
I added these tests to cover the preexisting functionality in items.go. I made sure the tests passed in main, before the rest of the changes in this PR.
cavalle
commented
Aug 29, 2023
| }, | ||
| "sigs": [ | ||
| "eyJhbGciOiJFUzI1NiIsImtpZCI6ImZmNzU5MTVmLWY2ZjgtNDU4Ny04OTBhLWNjZDhiODZiZjhmNSJ9.eyJ1dWlkIjoiNjc5YTJmMjUtNzQ4My0xMWVjLTk3MjItN2VhMmNiNDM2ZmY2IiwiZGlnIjp7ImFsZyI6InNoYTI1NiIsInZhbCI6ImQzNmM3NGUxOWJmNWYwMDk3NzM4Y2JmNTk3MGZiMjA1NDc5MmU5NDRiMmM3MWMwOWFmMGJjY2I0MmQzZGI1MzYifX0.iivLe0zUAMqlRmN4AJYgUIDhGcyBzYDIBJyTUj0sHBK3axNJC0JDPVKznfPOzShVfO3ILsvbuXxzVo-1sButvQ" | ||
| ] |
There was a problem hiding this comment.
I removed the signatures from the test envelopes as they weren't necessary, and rebuilding the files is (marginally) easier without them.
|
@samlown we left this pending. I think it's safe to merge, what do you think? |
|
@cavalle Sorry! missed this, yes! let's merge. I'll confirm on slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 WIP 🚧 Don't forget to upgrade thegoblmodule here once the changes in the PR above are released