Fix Panic in CLI Convert #24
Conversation
| @@ -123,6 +123,10 @@ func New(software *Software, zone l10n.Code, opts ...Option) (*Client, error) { | |||
| opt(c) | |||
| } | |||
|
|
|||
| if c.cert == nil { | |||
| return c, nil | |||
There was a problem hiding this comment.
Should it not raise an error instead?
There was a problem hiding this comment.
It depends on whether a certificate should be mandatory to convert a TicketBAI document. With these changes, if a user wants to convert a document with without a certificate it can (with empty signature and fingerprint).
If a user attempts to send a document from the CLI without a certificate an error is raised when attempting to load the certificate. If a user attempts to fingerprint the document it will do so with no problem, but if it attempts to sign it returns {"error":"signing: cannot sign without a certificate"}.
The way I see if we have a Convert() function we want to make accessible (it even has its CLI command), it should not require a certificate, especially because the result is not signed.
The CLI convert function does not add a certificate to the TicketBAI client. This makes sense as it does not send it to TicketBAI and a certificate is not needed. However, when creating the client it attempts to open a gateway connection with no certificate with leads to a panic.
I have added a nil check for the certificate so that if an invoice with no certificate is sent to the client, it doesn't try to open a gateway to the TicketBAI service.