Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: EN16931 mappings to GOBL #401

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: EN16931 mappings to GOBL #401

wants to merge 1 commit into from

Conversation

samlown
Copy link
Collaborator

@samlown samlown commented Oct 22, 2024

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents the show my changes in use, if appropriate.
  • When adding or modifying a tax regime or addon, I've added links to the source of the changes either structured or in the comments.
  • I've run go generate . to ensure that Schemas and Regime data are up to date.
  • All linter warnings have been reviewed and fixed.
  • I've been obsessive with pointer nil checks to avoid panics.
  • Requested a review from @samlown.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 78.73%. Comparing base (15397b4) to head (95b124a).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
tax/mapping_table.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
- Coverage   78.82%   78.73%   -0.10%     
==========================================
  Files         217      218       +1     
  Lines       10721    10734      +13     
==========================================
  Hits         8451     8451              
- Misses       1914     1927      +13     
  Partials      356      356              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samlown samlown mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant