Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org note #447

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Org note #447

wants to merge 3 commits into from

Conversation

samlown
Copy link
Collaborator

@samlown samlown commented Dec 13, 2024

Describe your changes

  • Moving cbc.Note to org.Note to be able to use extensions.
  • Added tax.ScenarioNote for note definitions, with conversion in org.Note
  • Added UNTDID 4451 - Text Subject list

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents the show my changes in use, if appropriate.
  • When adding or modifying a tax regime or addon, I've added links to the source of the changes either structured or in the comments.
  • I've run go generate . to ensure that Schemas and Regime data are up to date.
  • All linter warnings have been reviewed and fixed.
  • I've been obsessive with pointer nil checks to avoid panics.
  • The CHANGELOG.md has been updated with an overview of my changes.
  • Requested a review from @samlown.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.20%. Comparing base (302269b) to head (0faf91f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   82.88%   83.20%   +0.32%     
==========================================
  Files         242      243       +1     
  Lines       11875    11913      +38     
==========================================
+ Hits         9842     9912      +70     
+ Misses       1672     1640      -32     
  Partials      361      361              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samlown samlown requested a review from cavalle December 13, 2024 21:28
Copy link
Contributor

@cavalle cavalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants