fix: Values for section 6.2 should be numbers #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samlown it's ready for review |
samlown
reviewed
Sep 25, 2023
|
@samlown review comments addressed |
samlown
approved these changes
Sep 25, 2023
| @@ -1020,6 +1016,19 @@ func ignoredByJSONSchemaTags(tags []string) bool { | |||
| return tags[0] == "-" | |||
| } | |||
|
|
|||
| // toJSONNumber converts string to *json.Number. | |||
| // It'll aso return whether the number is valid. | |||
| func toJSONNumber(s string) (json.Number, bool) { | |||
There was a problem hiding this comment.
Not sure the bool is necessary given that you can test for an empty number, but we can go with that.
|
@samlown could you merge & release 0.9.1? |
|
New release pushed. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #98
Closes #99
https://json-schema.org/draft/2020-12/json-schema-validation.html#section-6.2