Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Recursive tag application for array fields #101

Merged
merged 3 commits into from
Sep 26, 2023
Merged

fix: Recursive tag application for array fields #101

merged 3 commits into from
Sep 26, 2023

Conversation

candiduslynx
Copy link
Contributor

Prior to this fix minLength would've been missing from the []string field

@candiduslynx
Copy link
Contributor Author

@samlown this is one of the things uncovered during the schema gen for CloudQuery.

samlown
samlown requested changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be great to just set up a specific test rather than updating the TestUser. There are examples at the bottom of reflect_test.go.

reflect_test.go Outdated
Comment on lines 114 to 115
MinLen []string `json:"min_len" jsonschema:"minLength=2"`
MinVal []float64 `json:"min_val" jsonschema:"minimum=2.5"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I'm pushing for tests here now is to define a separate and independent test rather than updating the massive TestUser. This reduces the number of updated test JSON files. What that be possible here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 6f92551.

Additionally, I removed recursive array ([][]... case) tags application per the impossibility of making decision where the tags belong to. This might lead to issue with [][]string jsonschema:"minLength=1"` not handled properly, but I think it's fine for now.

samlown
samlown approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks.

@samlown samlown merged commit 73900b4 into invopop:main Sep 26, 2023
2 checks passed
@candiduslynx candiduslynx deleted the fix/array-item-tags branch September 26, 2023 14:39
@candiduslynx
Copy link
Contributor Author

@samlown I've stumbled upon an interesting regression from this change, I'll make a follow-up PR (it's related to default behavior being used both for the array & for the underlying string

@candiduslynx candiduslynx mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlown samlown samlown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@candiduslynx @samlown