Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements and bug fixes #87

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

UncleSamSwiss
Copy link
Collaborator

Closes #60

const stats = await rawStatistics
.find()
.project<Statistics>({
adapters: { [name]: 1 },

Check failure

Code scanning / CodeQL

Remote property injection High

A property name to write to depends on a
user-provided value
.
.find()
.project<Statistics>({
adapters: { [name]: 1 },
versions: { [name]: 1 },

Check failure

Code scanning / CodeQL

Remote property injection High

A property name to write to depends on a
user-provided value
.
express/backend/src/api/adapter.ts Fixed Show fixed Hide fixed
express/backend/src/api/adapter.ts Fixed Show fixed Hide fixed
.find()
.project<Statistics>({
adapters: { [name]: 1 },
versions: { [name]: 1 },

Check failure

Code scanning / CodeQL

Remote property injection High

A property name to write to depends on a
user-provided value
.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name is now checked against some regexes that ensure it can only be a valid adapter name. These names can't be used for prototype pollution or similar attacks.

.project<Statistics>({
adapters: { [name]: 1 },
versions: { [name]: 1 },
date: 1,

Check failure

Code scanning / CodeQL

Remote property injection High

A property name to write to depends on a
user-provided value
.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name is now checked against some regexes that ensure it can only be a valid adapter name. These names can't be used for prototype pollution or similar attacks.

UncleSamSwiss and others added 3 commits January 17, 2025 17:11
…rough a stack trace

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@UncleSamSwiss UncleSamSwiss changed the title Statistics improvements Improvements and bug fixes Jan 17, 2025
@UncleSamSwiss UncleSamSwiss marked this pull request as ready for review January 17, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Statistics - add textual info / table
1 participant