Device type "ct" (Farbtemperatur) - multiple problems with state "ON"

[klein0r]

Describe the bug

• Create a new device of type ct
• Fill temperature, dimmer and on
• Save the device

Issues

1. Object ON has no role (should be switch.light)
2. Reopen the device in devices tab: input field for ON is empty (but reference exists)
3. Delete the device in devices tab: ON isn't deleted

Versions:

• Adapter version: 1.0.10

[Garfonso]

I stumbled upon the same issue. The problem is, that the State-Object ON is created without a role.

This probably has to do with two possible ON members in the type-detector pattern:

{role: /^switch\.light$/,                                 indicator: false, type: 'boolean', write: true,           name: 'ON',            required: false, defaultRole: 'switch.light'},
{role: /^switch$/,                                        indicator: false, type: 'boolean', write: true,           name: 'ON',            required: false},

The second one has no defaultRole defined. But this seems necessary, because items without a defaultRole get filtered out. I.e. if a defaultRole was set on both patterns, ON would show up two times in the states list (which happens on some devices, RGB-single for example).

I did not yet understand how the devices-adapter decides which role to use on object creation and how that works if there are two patterns with the same name. Furthermore, I tested a few other devices (airCondition) and it seems to happen on all of them.

For ct a fix in type-detector is easy (just make the regex more complex) but for other devices two patterns with the same name can be necessary (for example for accepting different types).

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of the adapter and tell us. Also check that all relevant details, logs and reproduction steps are included and update them if needed. Thank you for your contributions.
Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüft, ob das Problem auch in der aktuellsten Version des Adapters noch relevant ist, und teilt uns dies mit. Überprüft auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind bzw. aktualisiert diese. Vielen Dank für Eure Unterstützung.

[klein0r]

No!! Still an issue 😢

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of the adapter and tell us. Also check that all relevant details, logs and reproduction steps are included and update them if needed. Thank you for your contributions.
Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüft, ob das Problem auch in der aktuellsten Version des Adapters noch relevant ist, und teilt uns dies mit. Überprüft auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind bzw. aktualisiert diese. Vielen Dank für Eure Unterstützung.

[klein0r]

⬆️

[Garfonso]

are you sure that this is still an issue? Can you test with version 1.1.2, please? I can currently not reproduce this issue here.

[klein0r]

@Garfonso I'm not able to test that, because I get a blank page with every version >= 1.1.2

[Garfonso]

It should already be fixed in 1.1.2.

With 1.1.3 I also have the blank page issue. I fixed that in my fork (and my PR is still open). You can try to install from https://github.com/Garfonso/ioBroker.devices

[klein0r]

✅ (Tested with 1.1.5)