fix issues with double states #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some states in type-detector are duplicated (for example ON in lights). One of them has no default state (which is good, because it is not shown) but the simple find for some reason tends to find the state without default role, so a role is not assigned and the state is not detected by type-detector anymore and "lost" after saving. Now added a second find to make sure that the state with defaultRole is used, if existing. Not sure if the fallback is needed at all...
Garfonso
added a commit
to Garfonso/ioBroker.type-detector
that referenced
this pull request
Sep 30, 2022
Remove default roles for duplicate ON states (and add defaultUnit for dimmer in some cases) so that they don't show up in devices UI. Probably I added them in the first place. Sorry, did not understand how devices works. With PR ioBroker/ioBroker.devices#190 which makes sure to use the duplicate with defaultRole during creation, this should fix some issues in devices adapter.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some states in type-detector are duplicated (for example, ON in lights). One of them has no default state (which is good, because it is not shown) but the simple find for some reason tends to find the state without default role, so a role is not assigned, and the state is not detected by type-detector anymore and "lost" after saving.
Now added a second find to make sure that the state with defaultRole is used, if existing.
Not sure if the fallback is needed at all...
Related issues (some together with type-detector PR):
#159
#141
#106
#128