fix double on state in light devices #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove default roles for duplicate ON states (and add defaultUnit for dimmer in some cases) so that they don't show up in devices UI. Probably I added them in the first place. Sorry, did not understand how devices works. With PR ioBroker/ioBroker.devices#190 which makes sure to use the duplicate with defaultRole during creation, this should fix some issues in devices adapter.
because of array of states it was not detected if no cover was found... Maybe think about removing the array. It is currently the only pattern that needs it and it requires a lot of stuff later on. Also cover does not show up in devices, so there need to be changes there, too..
|
I fixed another issue with But the fix is quite ugly, IMHO. Also, the cover state does not show up in devices, so it seems devices does not yet support arrays of states. So maybe just get rid of the array there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove default roles for duplicate ON states (and add defaultUnit for dimmer in some cases) so that they don't show up in devices UI.
Probably, I added them in the first place. Sorry, did not understand how devices works.
With PR ioBroker/ioBroker.devices#190 which makes sure to use the duplicate with defaultRole during creation, this should fix some issues in devices adapter.