Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extended dialog: https://github.com/ioBroker/ioBroker.matter/is… #223

Merged
merged 10 commits into from
Dec 12, 2024

Conversation

GermanBluefox
Copy link
Contributor

…sues/181

Added ioBroker vendor icon: #192 Changed some texts: #168 Make info closable
Make it possible to show always qr-code: #138

Added ioBroker vendor icon: #192
Changed some texts: #168
Make info closable
Make it possible to show always qr-code: #138
@GermanBluefox GermanBluefox marked this pull request as draft December 10, 2024 21:53
@GermanBluefox GermanBluefox marked this pull request as ready for review December 11, 2024 21:39

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 25 out of 40 changed files in this pull request and generated no suggestions.

Files not reviewed (15)
  • package.json: Language not supported
  • src-admin/package.json: Language not supported
  • src-admin/src/i18n/de.json: Language not supported
  • src-admin/src/i18n/en.json: Language not supported
  • src-admin/src/i18n/es.json: Language not supported
  • src-admin/src/i18n/fr.json: Language not supported
  • src-admin/src/i18n/it.json: Language not supported
  • src-admin/src/i18n/nl.json: Language not supported
  • src-admin/src/i18n/pl.json: Language not supported
  • src-admin/src/i18n/pt.json: Language not supported
  • src-admin/src/i18n/ru.json: Language not supported
  • src-admin/src/i18n/uk.json: Language not supported
  • src-admin/src/App.tsx: Evaluated as low risk
  • src-admin/src/Tabs/Bridges.tsx: Evaluated as low risk
  • src-admin/src/Tabs/BridgesAndDevices.tsx: Evaluated as low risk
Comments skipped due to low confidence (2)

src-admin/src/components/InfoBox.tsx:7

  • The children prop should be React.ReactNode instead of string to allow more flexibility in the content.
children: string;

src-admin/src/Tabs/Devices.tsx:71

  • Missing error handling for the detectDevices function.
onOk={async (_oid, name) => {
@Apollon77
Copy link
Collaborator

Awesome. I also will update change log and update issues when I release

@Apollon77 Apollon77 merged commit 0280ad5 into main Dec 12, 2024
22 checks passed
@Apollon77 Apollon77 deleted the extra-info-gui branch December 12, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants