Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended info for separate devices in bridge #225

Merged
merged 9 commits into from
Dec 13, 2024
Merged

Conversation

GermanBluefox
Copy link
Contributor

@GermanBluefox GermanBluefox commented Dec 12, 2024

All GUI errors and enhancements are done. Only APP should be done.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 23 changed files in this pull request and generated 1 suggestion.

Files not reviewed (15)
  • io-package.json: Language not supported
  • src-admin/src/i18n/de.json: Language not supported
  • src-admin/src/i18n/en.json: Language not supported
  • src-admin/src/i18n/es.json: Language not supported
  • src-admin/src/i18n/fr.json: Language not supported
  • src-admin/src/i18n/it.json: Language not supported
  • src-admin/src/i18n/nl.json: Language not supported
  • src-admin/src/i18n/pl.json: Language not supported
  • src-admin/src/i18n/pt.json: Language not supported
  • src-admin/src/i18n/ru.json: Language not supported
  • src-admin/src/i18n/uk.json: Language not supported
  • src-admin/src/App.tsx: Evaluated as low risk
  • src-admin/src/Tabs/Bridges.tsx: Evaluated as low risk
  • src-admin/src/Tabs/BridgesAndDevices.tsx: Evaluated as low risk
  • src-admin/src/Tabs/Controller.tsx: Evaluated as low risk
Comments skipped due to low confidence (4)

src-admin/src/components/DeviceDialog.tsx:262

  • The warning message 'Warning about 15 devices' is unclear. It should be more descriptive, such as 'Adding more than 15 devices to a bridge may cause performance issues. Please consider commissioning the bridge first.'
{I18n.t('Warning about 15 devices')}

src-admin/src/Tabs/Options.tsx:373

  • The InfoBox component should handle unexpected 'type' values more gracefully. Consider adding a default case or validation for the 'type' prop.
<InfoBox type="info">{I18n.t('Info about Alexa Bridge')}</InfoBox>

src-admin/src/Tabs/Options.tsx:22

  • There should be a space after the comma in the import statement.
{Check, Close, LayersClear, AutoAwesome, Clear, VisibilityOff, Visibility}

src-admin/src/Tabs/Options.tsx:441

  • The 'autocomplete' attribute should be 'autoComplete' to match JSX conventions.
<IconButton size="small" onClick={() => this.props.onChange('login', '')}>

src-admin/src/components/WelcomeDialog.tsx Show resolved Hide resolved
@Apollon77
Copy link
Collaborator

Thanks, I will move the welcomeDialog to info folder, but else all fine

@Apollon77 Apollon77 merged commit 58ed18c into main Dec 13, 2024
22 checks passed
@Apollon77 Apollon77 deleted the extended-info-device branch December 13, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants