fix: use shell to spawn npm on Windows
#595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
changed the title
npm on Windows
AlCalzone
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a windows "security fix" release around 15.4.2024 spawing a .cmd (or .bat) file requires an additional option shell:true.
Tests on windows stalled (until timeout occured) starting 15.4.2024 when spawing npm subcommand. This PR ass the required shell:true option.
TESTING:
Unchanged version should hang on windows tests, at (Re)Installing js-controller, i.e.
https://github.com/iobroker-community-adapters/ioBroker.haier/actions/runs/8703117264/job/23868610356
After applying the fix tests should not time out any longer
NOTE:
Tests on Linux and Mac are NOT affected