Allow (deprecated) HTML as admin UI in package tests #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
requested changes
Apr 17, 2024
src/tests/packageFiles/index.ts
Outdated
| @@ -259,6 +259,7 @@ export function validatePackageFiles(adapterDir: string): void { | |||
| it("The adapter uses Material UI or JSON Config for the admin UI", () => { | |||
There was a problem hiding this comment.
Suggested change
| it("The adapter uses Material UI or JSON Config for the admin UI", () => { | |
| it("The adapter uses a supported admin UI", () => { |
Co-authored-by: AlCalzone <d.griesel@gmx.net>
AlCalzone
reviewed
Apr 17, 2024
Co-authored-by: AlCalzone <d.griesel@gmx.net>
AlCalzone
approved these changes
Apr 17, 2024
AlCalzone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the current schema still allows HTML UI and HTML UI still works as expected the adapetr checks should allow it too.
Otherwise those old adapter need to disable the package tests completly which is worse (in my opinion).
Link to io-package.json schema: https://github.com/ioBroker/ioBroker.js-controller/blob/79fe972a23cee7c7fbf65d19aba044827f843d25/schemas/io-package.json#L796