Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #274. #299

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

neopholus
Copy link
Contributor

@neopholus neopholus commented Aug 4, 2024

Now it is tracked whether a device comes from the configuration or from the auto discovery:

  • Devices from the configuration are created using the name from the configuration as it was done before 3.0.3 introduced MAC addresses as names for devices that has been auto-discovered. Unfortunately, devices added to the device tab of the configuration broke with that, as also there MAC addresses would have been used as name and not the configured name. For devices in different subnets, the getMAC failed, of course.
  • Devices from the auto discovery are using MAC address as name, as introduced with 3.0.3.

- Now it is tracked whether a device comes from the configuration or from the auto discovery.
- Devices from the configuration are created using the name from the configuration
- Devices from the auto discovery are using MAC address as name.
@mcm1957
Copy link
Member

mcm1957 commented Aug 9, 2024

@raintonr said at #298 (comment)

Someone made a release which introduced a bug, which #274 is suppose to fix. Sorry, but I just don't have time to work on this right now. I leave it's merge up to you guys.

Anyway, some of us installed the latest release when it was available, noticed the bug and downgraded.

@mcm1957 mcm1957 removed the request for review from raintonr August 9, 2024 11:31
@mcm1957 mcm1957 requested a review from raintonr October 9, 2024 11:20
Copy link
Contributor

@raintonr raintonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raintonr raintonr merged commit 123dc8b into iobroker-community-adapters:master Oct 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants