Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] grammatical error in mkiocccentry(1) #1036

Closed
1 task done
lcn2 opened this issue Dec 24, 2024 · 5 comments
Closed
1 task done

[Bug] grammatical error in mkiocccentry(1) #1036

lcn2 opened this issue Dec 24, 2024 · 5 comments
Assignees
@xexyl
Labels
bug Something isn't working top priority This a top priory critical path issue for next milestone

Comments

@lcn2
Copy link
Contributor

lcn2 commented Dec 24, 2024

Is there an existing issue for this?

  • I have searched for existing issues and did not find anything like this

Describe the bug

The code prints:

You title must be between 1 and 32 ASCII characters long.

What you expect

The code prints:

Your title must be between 1 and 32 ASCII characters long.

Environment

  • OS: yes
  • Device: certainly
  • Compiler: obviously

bug_report.sh output

n/a

Anything else?

Bug was reported by Eliot Lear while testing mkiocccentry(1).

This is a LOW PRIORITY BUG. We are simply documenting this for action after IOCCC28.
@lcn2 lcn2 added bug Something isn't working post-IOCCC28 All work and comments delayed until post-IOCCC28 and post IOCCC judge vacation. labels Dec 24, 2024
@xexyl
Copy link
Contributor

xexyl commented Dec 24, 2024

I'm surprised that slipped through actually. I guess from all the other things that were going on.

I"m happy to fix that when it's time.

@lcn2 lcn2 added top priority This a top priory critical path issue for next milestone and removed post-IOCCC28 All work and comments delayed until post-IOCCC28 and post IOCCC judge vacation. labels Dec 24, 2024
@lcn2 lcn2 mentioned this issue Dec 24, 2024
Closed
1 task
@lcn2
Copy link
Contributor Author

lcn2 commented Dec 25, 2024

We believe we have addressed all of the current questions that still need answering at this time. If we've missed something or something else needs to be clarified, please ask again.

@xexyl
Copy link
Contributor

xexyl commented Dec 25, 2024

Do you wish me to fix this along with the other issues? I'll not ask this in another issue (besides the one I just did of course) so as to save you time.

@lcn2
Copy link
Contributor Author

lcn2 commented Dec 26, 2024

Do you wish me to fix this along with the other issues? I'll not ask this in another issue (besides the one I just did of course) so as to save you time.

Yes please.

@xexyl
Copy link
Contributor

xexyl commented Dec 26, 2024

Do you wish me to fix this along with the other issues? I'll not ask this in another issue (besides the one I just did of course) so as to save you time.

Yes please.

This one is done.. unfortunately you'll see a commit and it being reverted. I have no way to do that otherwise without bring in the jstrdecode -h bug (though as said in jparse it's fixed but it also has the validating of JSON first).

I'll look at the other issues and see if I can get them in too. In a little bit I have to go afk a while but I hope to do more when back.

xexyl added a commit to xexyl/mkiocccentry that referenced this issue Dec 26, 2024
@xexyl
Fix issues ioccc-src#1036, ioccc-src#1035 and ioccc-src#1033
1957cb4 
The issues in respective order:

- Typo fix in mkiocccentry.c ('You title must ...' -> 'Your title must
...').
- mkiocccentry UUID type 4 was too strict
- Renamed makefile.local -> Makefile.local. This does NOT address issue ioccc-src#1034!

Updated version of mkiocccentry due to the above changes. For the second
one new macros are in soup/limit_ioccc.h so the soup version has been
updated as well.

Due to the mkiocccentry version change many JSON files were updated so
this is a large commit.

Something that should be pointed out is that the dyn_array and dbg repos
should be updated to match the Makefile changes. This can be done later.
I am too tired to do that now but what this means is that if one were to
sync dbg or dyn_array to here it would roll it back.

Another thing to point out is that another couple commits will likely be
included as a mistake was made on my end and unfortunately that commit
was pushed to my fork. This means I had to do git revert on it.
@lcn2 lcn2 closed this as completed Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xexyl xexyl

Labels
bug Something isn't working top priority This a top priory critical path issue for next milestone
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lcn2 @xexyl