Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad typo fix in prep.sh, improve test workflow #1010

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

xexyl
Copy link
Contributor

@xexyl xexyl commented Oct 30, 2024

The typo was that the variable LOGFILE had no G.

The workflow now runs make bug_report. This does run make test again but it seems like a good thing to run as it can help uncover more problems that might not be noticed otherwise. The bug_report.sh script is slow but this seems like a worthy thing to do.

The typo was that the variable LOGFILE had no G.

The workflow now runs make bug_report. This does run make test again but
it seems like a good thing to run as it can help uncover more problems
that might not be noticed otherwise. The bug_report.sh script is slow
but this seems like a worthy thing to do.
@xexyl
Copy link
Contributor Author

xexyl commented Oct 30, 2024

I tested the bug_report part in the jparse repo and it works just fine. Hopefully nothing has to be done here.

Some important bug fixes were made in the jparse repo too. Will make a pull request for that.

Copy link
Contributor

@lcn2 lcn2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch ‼️

@lcn2 lcn2 merged commit 68d096b into ioccc-src:master Oct 30, 2024
3 checks passed
@xexyl
Copy link
Contributor Author

xexyl commented Oct 30, 2024

Good catch ‼️

I don't know which of us wrote that but it's odd that I never saw it before. Very possibly it was a substitute towards the last time that script was updated (I recall making some of the names more consistent). Oh well, at least it's fixed now.

Best wishes with your time away!

@xexyl xexyl deleted the logfile branch October 30, 2024 19:10
@xexyl
Copy link
Contributor Author

xexyl commented Oct 30, 2024

An interesting thing with the make bug_report in the workflow though.

## RUNNING: git status on the code
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   jparse/jparse.lex.ref.h
	modified:   jparse/jparse.ref.c

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	checknr/
	independ/
	jparse/lex.jparse_.c
	picky/
	seqcexit/

no changes added to commit (use "git add" and/or "git commit -a")

## git status ABOVE

That's because of the dependencies. Probably it's not a big deal as everything should be cleaned up afterwards. But still something noteworthy. The workflow script could remove those subdirectories before running make bug_report and as for lex.jparse_.c I'm not sure about. Might be from make parser-o but the file is not seen after running the script as it removes that file too.

Anyway just figured I'd note it even if it doesn't make any real difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants