-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync jparse/ from jparse repo #1029
Conversation
This adds a new utility function that will be used in required updates for chkentry(1) post IOCCC28 and updates the util test code (which tests the new function). A minor change in the jstrencode.1 man page was also done though wording might be needing in fixing (that can come another time however as other changes might be required).
Okay all good I think! Thanks for waiting for these useful changes. Back later in some form .. though that might only be the jparse repo issues. |
|
Ah .. missed an arg. Let me fix real quick. Hope I have time. Otherwise in a while. |
Waiting for you to fix the "too few args" issue. |
Hmm .. conflicting files how? And how do you enable that test btw? I tried to see but didn't seem to find it or be able to enable it. |
Okay will have to fix in a bit. Sorry! |
It is one of the security workflows. See |
We will wait until you resolve the merge conflict. It is probably better if you do that on your end. |
We have to shower and pack up the hotel room for a checkout. Will come back in about an hour or so. |
Could have sworn I had it .. will check in a while. |
I will. Strange problem though .. I just copied the new file over and committed it yet it has the merge conflict ? I have to go afk now .. Safe travels! |
Hopefully this solves it now ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
All good! |
I can't seem to get that extra check to work. Strange. I rolled back the changes. Maybe will look at it another time. Not many differences besides removed comments in the two files. Major difference is jparse has to run extra steps to get compilation to work: obviously for the external libraries. |
This adds a new utility function that will be used in required updates for chkentry(1) post IOCCC28 and updates the util test code (which tests the new function).
A minor change in the jstrencode.1 man page was also done though wording might be needing in fixing (that can come another time however as other changes might be required).