Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix picky rule in Makefiles #911

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Fix picky rule in Makefiles #911

merged 1 commit into from
Jul 14, 2024

Conversation

xexyl
Copy link
Contributor

@xexyl xexyl commented Jul 13, 2024

As the GitHub repo was changed in the workflow it should also refer to it in the Makefiles.

As the GitHub repo was changed in the workflow it should also refer to
it in the Makefiles.
Copy link
Contributor

@lcn2 lcn2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @xexyl

@lcn2
Copy link
Contributor

lcn2 commented Jul 14, 2024

Well, we approve of this change, we will let this pull request sit while we try to figure out why we have to "approve and run the workflow for this repo. So don't be dismayed if it sits for a while we intend to merge it.

@xexyl
Copy link
Contributor Author

xexyl commented Jul 14, 2024

Well, we approve of this change, we will let this pull request sit while we try to figure out why we have to "approve and run the workflow for this repo. So don't be dismayed if it sits for a while we intend to merge it.

No rush on my behalf - but thanks for the note. Hope you have a great night.

@SirWumpus
Copy link
Contributor

@lcn2 Did you see my comment from this morning? #905 (comment)

@lcn2
Copy link
Contributor

lcn2 commented Jul 14, 2024

@lcn2 Did you see my comment from this morning? #905 (comment)

Yes, it has been marked with a 👀 which means we intend to look at it.

Meanwhile we have issues with calc, with a new "bin tool" we are writing, ordering appliances related to the on-going construction at TreeHouse, and the prep for the UT show, and the volcanic swarm at Mt. Lassen, and trying to have a weekend.

We DO appreciate your advice, and when we are able to cycle around to it, follow thru and test your excellent suggestion.

@SirWumpus
Copy link
Contributor

Sorry (I'm Canadian) didn't mean to pester. Outside of puppy, not much of life (which is fine and quiet for now).

@lcn2
Copy link
Contributor

lcn2 commented Jul 14, 2024

Sorry (I'm Canadian) didn't mean to pester. Outside of puppy, not much of life (which is fine and quiet for now).

No worries, and we appreciate your reminding us of your efforts to try and solve the mystery. We were simply trying to explain why we are focused elsewhere at the moment.

Also, as a Canadian, it is your right to use Sorry in a Canadian 🇨🇦 way 😄.

@xexyl
Copy link
Contributor Author

xexyl commented Jul 14, 2024

@lcn2 Did you see my comment from this morning? #905 (comment)

Yes, it has been marked with a 👀 which means we intend to look at it.

Meanwhile we have issues with calc, with a new "bin tool" we are writing, ordering appliances related to the on-going construction at TreeHouse, and the prep for the UT show, and the volcanic swarm at Mt. Lassen, and trying to have a weekend.

New bin tool related to calc? Or the other repo for the IOCCC?

And I remember TreeHouse! Did you ever get a thing to memorialise the tree that had to be cut down?

UT show makes me think of Unfinished Tales but I'm sure you mean something else.

Volcanic ... is that another eruption going on? I know some days back Etna was erupting again. Some beautiful pictures.

Hope the weekend is going well. I'll be off shortly. I hope I can do more tomorrow (as in more than what I did today).

We DO appreciate your advice, and when we are able to cycle around to it, follow thru and test your excellent suggestion.

I also appreciate this.

@xexyl
Copy link
Contributor Author

xexyl commented Jul 14, 2024

Sorry (I'm Canadian) didn't mean to pester. Outside of puppy, not much of life (which is fine and quiet for now).

Film? But I guess that it's good that you have your puppy. Life without dogs or cats (for me both but I know some people like only one or the other and some neither) can be dreary.

Our dogs have been needing a lot of attention lately. They're German Shepherd mixes and so not lap dogs but one has been trying to be a lap dog and we end up letting her. Planning on bathing them tomorrow but that might not work out with how they've been feeling ...

Have a good night you two. Off for the night.

@xexyl
Copy link
Contributor Author

xexyl commented Jul 14, 2024

Good catch @xexyl

As far as this ... I initially put the clone to yours but then I thought a moment and remembered it was a fork. So that's why I changed it. But when you decided it would be better for this repo to be your copy I thought I'd fix this part.

@lcn2
Copy link
Contributor

lcn2 commented Jul 14, 2024

We may have solved the problem of having to approve all actions.

@lcn2 lcn2 merged commit 77f0520 into ioccc-src:master Jul 14, 2024
3 checks passed
@xexyl
Copy link
Contributor Author

xexyl commented Jul 14, 2024

We may have solved the problem of having to approve all actions.

That's great news! I can do a test commit to see .. shortly.

@xexyl xexyl deleted the picky-makefile branch July 14, 2024 12:46
@xexyl
Copy link
Contributor Author

xexyl commented Jul 14, 2024

You fixed it! Check this screenshot (coming up in next comment) ..

@xexyl
Copy link
Contributor Author

xexyl commented Jul 14, 2024

Screenshot 2024-07-14 at 05 48 48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants