Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few error messages in jparse/json_sem.c #914

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

xexyl
Copy link
Contributor

@xexyl xexyl commented Jul 14, 2024

In some of the functions sem_member_value_*() (those that validate JSON parse node types) the error message (if the type was wrong) reported incorrectly the type expected and in particular all of them suggested the type should be JTYPE_BOOL but none of the functions were for booleans (though all were for numbers I think).

In some of the functions sem_member_value_*() (those that validate JSON
parse node types) the error message (if the type was wrong) reported
incorrectly the type expected and in particular all of them suggested
the type should be JTYPE_BOOL but none of the functions were for
booleans (though all were for numbers I think).
Copy link
Contributor

@lcn2 lcn2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting bug and nice 👍 fix @xexyl

@lcn2 lcn2 merged commit 529ef72 into ioccc-src:master Jul 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants