-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to restrict CodeQL paths - #917 #918
Conversation
This is based on discussion started by @SirWumpus. Since he thinks this might be all we need this is a test on the process. If there is a problem, syntax error or something else, it can then be revised.
Let's see if this works okay .. if not I'll see about updating it though maybe will require discussion. I do have to go afk soon however. |
All good! Thanks @SirWumpus! I'll copy over to the jparse repo even though it's a placeholder at this point. |
Checking in jparse now .. |
BTW the scan results will appear under the |
Thanks. Oddly even though the file is there I only see the test.yml running. Any idea why that might be? Well I'll check that section too as maybe the test.yml is where I looked and the CodeQL is in the section you mention? |
Over there CodeQL is only run on a schedule. Any idea what needs to change so it's on commit ? |
Oh! It's because the files were not modified maybe? |
Trying that now .. updated Makefile. |
I don't see anything .. hmm. |
Ah! I see it under Actions. It's running now. So that's good. |
It worked! Thanks again! |
You should be able to manually start a workflow (if you have write access) after fixing any restriction problems. You should see both runs in Actions (All Workflows); Security results talk a couple of minutes to do and appear later. |
I do indeed have access but I had to look at Actions to find it. All good it seems. It's not as detailed as here but that's because there's no code except a single C file with a simple UPDATE 0Oh .. that's because that's the test.yml file. That does show it fine. |
Will likely be afk soon. When back I'll probably look at the other repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SirWumpus and @xexyl, lets check this in and see what happens
Well it seemed to pass so that's encouraging at least. Hopefully it's not a mistake that will end up with problems another time down the road due to some unforeseen reason. Anyway you're welcome and on my behalf I thank @SirWumpus too! |
This is based on discussion started by @SirWumpus. Since he thinks this might be all we need this is a test on the process. If there is a problem, syntax error or something else, it can then be revised.