Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to restrict CodeQL paths - #917 #918

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Conversation

xexyl
Copy link
Contributor

@xexyl xexyl commented Jul 27, 2024

This is based on discussion started by @SirWumpus. Since he thinks this might be all we need this is a test on the process. If there is a problem, syntax error or something else, it can then be revised.

This is based on discussion started by @SirWumpus. Since he thinks this
might be all we need this is a test on the process. If there is a
problem, syntax error or something else, it can then be revised.
@xexyl
Copy link
Contributor Author

xexyl commented Jul 27, 2024

Let's see if this works okay .. if not I'll see about updating it though maybe will require discussion. I do have to go afk soon however.

@xexyl
Copy link
Contributor Author

xexyl commented Jul 27, 2024

All good! Thanks @SirWumpus! I'll copy over to the jparse repo even though it's a placeholder at this point.

@xexyl
Copy link
Contributor Author

xexyl commented Jul 27, 2024

Checking in jparse now ..

@SirWumpus
Copy link
Contributor

BTW the scan results will appear under the Security > Code Scanning section (not under Actions doh).

@xexyl
Copy link
Contributor Author

xexyl commented Jul 27, 2024

BTW the scan results will appear under the Security > Code Scanning section (not under Actions doh).

Thanks. Oddly even though the file is there I only see the test.yml running. Any idea why that might be? Well I'll check that section too as maybe the test.yml is where I looked and the CodeQL is in the section you mention?

@xexyl
Copy link
Contributor Author

xexyl commented Jul 27, 2024

Over there CodeQL is only run on a schedule. Any idea what needs to change so it's on commit ?

@xexyl
Copy link
Contributor Author

xexyl commented Jul 27, 2024

Oh! It's because the files were not modified maybe?

@xexyl
Copy link
Contributor Author

xexyl commented Jul 27, 2024

Trying that now .. updated Makefile.

@xexyl
Copy link
Contributor Author

xexyl commented Jul 27, 2024

I don't see anything .. hmm.

@xexyl
Copy link
Contributor Author

xexyl commented Jul 27, 2024

Ah! I see it under Actions. It's running now. So that's good.

@xexyl
Copy link
Contributor Author

xexyl commented Jul 27, 2024

It worked! Thanks again!

@SirWumpus
Copy link
Contributor

You should be able to manually start a workflow (if you have write access) after fixing any restriction problems. You should see both runs in Actions (All Workflows); Security results talk a couple of minutes to do and appear later.

@xexyl
Copy link
Contributor Author

xexyl commented Jul 27, 2024

You should be able to manually start a workflow (if you have write access) after fixing any restriction problems. You should see both runs in Actions (All Workflows); Security results talk a couple of minutes to do and appear later.

I do indeed have access but I had to look at Actions to find it. All good it seems. It's not as detailed as here but that's because there's no code except a single C file with a simple main() and the test (and similar) Makefile rules don't do anything yet.

UPDATE 0

Oh .. that's because that's the test.yml file. That does show it fine.

@xexyl
Copy link
Contributor Author

xexyl commented Jul 27, 2024

Will likely be afk soon. When back I'll probably look at the other repo.

Copy link
Contributor

@lcn2 lcn2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SirWumpus and @xexyl, lets check this in and see what happens

@lcn2 lcn2 merged commit 01ce1b4 into ioccc-src:master Jul 27, 2024
3 checks passed
@xexyl
Copy link
Contributor Author

xexyl commented Jul 27, 2024

Thanks @SirWumpus and @xexyl, lets check this in and see what happens

Well it seemed to pass so that's encouraging at least. Hopefully it's not a mistake that will end up with problems another time down the road due to some unforeseen reason. Anyway you're welcome and on my behalf I thank @SirWumpus too!

@xexyl xexyl deleted the codeql branch July 27, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants