Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 1992/imc more like original + formatting #1328

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Conversation

xexyl
Copy link

@xexyl xexyl commented Nov 9, 2023

The original imc code assumed that exit(3) returns a value but it was
changed to use the comma operator:

#define                       ext(a) (exit(a),0)

Instead of this, I redefined exit like I have done with other fixes, to
make it more like the original.

I also format/typo checked the README.md file.

I cannot test the raster files as I don't have access to a Sun box but
the text seems good. I tried some of the example commands given by the
author but I did not try all the options. What I tested looks good as
best I can tell.

For fun and because I have fond memories I added a link to dot matrix
printers where the author noted that they are useful, though I guess
most people don't have access to them nowadays (and many don't even know
what they are which is another reason for a link :-) ).

This should complete 1992/imc.

It came to my attention that some versions of clang trigger and
additional warning that has to be disabled in order to compile the a.c
that the entry generates. This has been fixed.

I am NOT including the translate.c file that I wrote to come up with the
proper string (it encrypts and decrypts though with some limitations) as
I don't want to give it away too much. I MIGHT include it on my website
another time in case it is ever necessary (though the hope and belief is
it won't be but who knows with clang). This would be AFTER the website
has been looked at. This has already taken too much time to fix. It is
now time to finish 1992 and then go on to 1993.
The original imc code assumed that exit(3) returns a value but it was
changed to use the comma operator:

    #define			  ext(a) (exit(a),0)

Instead of this, I redefined exit like I have done with other fixes, to
make it more like the original.

I also format/typo checked the README.md file.

I cannot test the raster files as I don't have access to a Sun box but
the text seems good. I tried some of the example commands given by the
author but I did not try all the options. What I tested looks good as
best I can tell.

For fun and because I have fond memories I added a link to dot matrix
printers where the author noted that they are useful, though I guess
most people don't have access to them nowadays (and many don't even know
what they are which is another reason for a link :-) ).

This should complete 1992/imc.
@xexyl
Copy link
Author

xexyl commented Nov 9, 2023

With this commit I believe the only ones left in 1992 are vern and nathan and thus it should be possible to finish 1992 today!

I will also very likely be able to start 1993. I rather doubt I'll be able to finish 1993 today but maybe tomorrow or the next day. As long as I finish a year in a couple days each I think we're good for finishing the issues #2 and #3 before the end of the year especially as it might happen that some years go quicker. It's highly likely that there are numerous other entries that do not need to have any edits but that's not yet known of course.

However I need another break .. might be longer this time.

@lcn2 lcn2 merged commit 890dd4c into ioccc-src:master Nov 9, 2023
@lcn2
Copy link

lcn2 commented Nov 9, 2023

Thanks 🙏 @xexyl

@xexyl
Copy link
Author

xexyl commented Nov 9, 2023

Thanks 🙏 @xexyl

You're very welcome.

I'll be afk for real now .. back in a while and when I do I plan to finish 1992! If you want me to stop my rhymes just give me a dime and I'll stop the chimes or at least I'll stop mine and the mimes!

@xexyl xexyl deleted the 1992imc branch November 11, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants