Change LIBS to LDFLAGS in Makefiles #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to make it more standard which further allows one to run make on some other source code, say because they want to try and fix an entry but forget to update the Makefile. Or if they're the author they can not worry about it in some cases. But since LDFLAGS is the standard way it seems better to have the LIBS variable in the Makefile be LDFLAGS. Maybe there is a reason to not have this and I'm happy to close this in that case but it does seem better this way so I'm doing this commit.
|
Another reason to have this is that the Makefile.example in the other repo also uses LDFLAGS. |
|
This is a very reasonable charge @xexyl |
Glad you agree and happy to help! I just added the missing files from Yusuke. I have very little time before I must leave. I might be able to do more later on but I'm not sure of that. I might try and get the FAQ updated for original code but I'm not sure if I will get that in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make it more standard which further allows one to run make on some other source code, say because they want to try and fix an entry but forget to update the Makefile. Or if they're the author they can not worry about it in some cases. But since LDFLAGS is the standard way it seems better to have the LIBS variable in the Makefile be LDFLAGS.
Maybe there is a reason to not have this and I'm happy to close this in that case but it does seem better this way so I'm doing this commit.