Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

450 generate schemaorg to prov mapping #451

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

pbuttigieg
Copy link
Collaborator

@pbuttigieg pbuttigieg commented Jul 11, 2024

Addressing #450

A GSheet to make the mapping editing easier, here.

@pbuttigieg pbuttigieg self-assigned this Jul 11, 2024
@pbuttigieg pbuttigieg linked an issue Jul 11, 2024 that may be closed by this pull request
Core PROV model mapping
@pbuttigieg
Copy link
Collaborator Author

pbuttigieg commented Jul 11, 2024

The core PROV terms (what are referred to as Starting Point terms) are mostly covered.

SmartSelect_20240711_141633_Chrome

I'm not convinced that adding the Expanded terms or the Qualified terms is really wise - these, especially the Qualified terms, look like PROV got carried away with itself. The semantics are either better handed by generic models like schema.org, or are convoluted. There may be a way to map via potentialActions, however.

Complete Starting Point map
@pbuttigieg pbuttigieg marked this pull request as ready for review July 11, 2024 12:30
@pbuttigieg pbuttigieg requested a review from fils July 11, 2024 12:30
@pbuttigieg
Copy link
Collaborator Author

pbuttigieg commented Jul 11, 2024

The Expanded terms are actually reasonably mappable. But things like Collections etc are not appropriate in the PROV domain - this is mission creep on PROV's part. The same is true for Person, Organization, etc. We can still map it I suppsoe, but this is by no means a vote of confidence of such terms.

SmartSelect_20240711_190126_Chrome

@pbuttigieg
Copy link
Collaborator Author

pbuttigieg commented Jul 11, 2024

xref ESIPFed/science-on-schema.org#211

@ashepherd I think ProvONE has the same issues of mission creep as the expanded and qualifying PROV terms. We can still map, but I think the PROV realm is reinventing things unnecessarily.

Switched PROV prefix to vanilla prov:, added rdfs for specialisations, added Expanded PROV terms as shown in core model figure, with one or two others (added opportunistically) from https://www.w3.org/ns/prov
@pbuttigieg pbuttigieg marked this pull request as draft July 12, 2024 21:25
Added more mapping metadata to SSSOM
@pbuttigieg
Copy link
Collaborator Author

@matentzn this may be interesting to you, and a quick check of this SSSOM would be appreciated.

@matentzn
Copy link

schema-prov.sssom.txt

@pbuttigieg I fixed a few syntactic bugs. Would you like me to implement a sssom mapping registry for ODIS with mapping file validation etc?

@pbuttigieg
Copy link
Collaborator Author

Thanks @matentzn

What would the registry entail? We'll likely have more SSSOM files on the way, thus it sounds sensible

@pbuttigieg
Copy link
Collaborator Author

Here is an example:

https://github.com/mapping-commons/mh_mapping_initiative

Mappings: https://github.com/mapping-commons/mh_mapping_initiative/tree/master/mappings Registry file: https://github.com/mapping-commons/mh_mapping_initiative/blob/master/registry.yml QC checking: https://github.com/mapping-commons/mh_mapping_initiative/blob/master/.github/workflows/qc.yml

Its easy enough to set up, and I am happy to donate one to you!

@matentzn Sounds great! I'm for it, but I'll have to clear this with the rest of the team.

I'm assuming creating and maintaining mappings in the commons is open source and at no cost?

@matentzn
Copy link

I'm assuming creating and maintaining mappings in the commons is open source and at no cost?

100%, we can move it to your own repo if you like!

@matentzn
Copy link

matentzn commented Aug 4, 2024

@pbuttigieg I have created a minimal mapping registry for you here for inspection:

https://github.com/matentzn/odis-mapping-commons

Here is an example of a PR introducing a breaking change so you can see how QC works:

matentzn/odis-mapping-commons#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate schema.org to PROV mapping
2 participants