448 create book section for implementing care principles for indigenous data #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ublishingPrinciples and ethicsPolicy
…s-for-indigenous-data' of https://github.com/localcontexts/odis-arch into 448-create-book-section-for-implementing-care-principles-for-indigenous-data
…added, otc notice metadata
jmckenna
reviewed
Oct 16, 2024
|
|
||
| As Ocean InfoHub is leveraging Schema.org we are using schema.org/CreativeWorks for this type. Any of the properties of Label seen there are valid to use in such a record. | ||
|
|
||
| ```{literalinclude} ../../../odis-in/dataGraphs/thematics/CreativeWork/graphs/local-contexts-notice.json |
There was a problem hiding this comment.
Suggested change
| ```{literalinclude} ../../../odis-in/dataGraphs/thematics/CreativeWork/graphs/local-contexts-notice.json | |
| ```{literalinclude} ../../../odis-in/dataGraphs/thematics/creativeWork/graphs/localContexts-label.json |
to match the current structure of the odis-in repo
jmckenna
reviewed
Oct 16, 2024
|
|
||
| As Ocean InfoHub is leveraging Schema.org we are using schema.org/CreativeWorks for this type. Any of the properties of Label seen there are valid to use in such a record. | ||
|
|
||
| ```{literalinclude} ../../../odis-in/dataGraphs/thematics/CreativeWork/graphs/local-contexts-label.json |
There was a problem hiding this comment.
Suggested change
| ```{literalinclude} ../../../odis-in/dataGraphs/thematics/CreativeWork/graphs/local-contexts-label.json | |
| ```{literalinclude} ../../../odis-in/dataGraphs/thematics/creativeWork/graphs/localContexts-label.json |
to match the current structure of the odis-in repo
jmckenna
reviewed
Oct 16, 2024
|
|
||
| As Ocean InfoHub is leveraging Schema.org we are using [schema.org/Project](https://schema.org/Project) for this type. Any of the properties of Project seen there are valid to use in such a record. | ||
|
|
||
| ```{literalinclude} ../../../odis-in/dataGraphs/thematics/projects/graphs/local-contexts-project-example.json |
There was a problem hiding this comment.
Suggested change
| ```{literalinclude} ../../../odis-in/dataGraphs/thematics/projects/graphs/local-contexts-project-example.json | |
| ```{literalinclude} ../../../odis-in/dataGraphs/thematics/projects/graphs/localContexts-project-example.json |
to match the current changes in the PR in the odis-in repo
jmckenna
reviewed
Oct 16, 2024
| "@vocab": "https://schema.org/" | ||
| }, | ||
| "@type": "Project", | ||
| "@id": "https://example.org/id/XYZ", |
There was a problem hiding this comment.
Suggested change
| "@id": "https://example.org/id/XYZ", | |
| "@id": "https://example.org/permanentUrlToThisJsonDoc", |
all examples in the odis-in repo now use this example url for @id
jmckenna
reviewed
Oct 16, 2024
| "@vocab": "https://schema.org/" | ||
| }, | ||
| "@type": "Project", | ||
| "@id": "https://example.org/id/XYZ", |
There was a problem hiding this comment.
Suggested change
| "@id": "https://example.org/id/XYZ", | |
| "@id": "https://example.org/permanentUrlToThisJsonDoc", |
jmckenna
reviewed
Oct 16, 2024
| "@vocab": "https://schema.org/" | ||
| }, | ||
| "@type": "Project", | ||
| "@id": "https://example.org/id/XYZ", |
There was a problem hiding this comment.
Suggested change
| "@id": "https://example.org/id/XYZ", | |
| "@id": "https://example.org/permanentUrlToThisJsonDoc", |
|
@arojas1 thanks for all of this, it is excellent. A minor/general comment is that I try to limit all text lines (the paragraphs near the top of each of the files in this PR, for example) to around 80 or 90 characters in length - as it makes it easier to read the line when editing, and not have to scroll & scroll to the right to read the many sentences on the one line in your local editing software. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the ODIS Book.
Drafting:
Internal Review:
cc: @pbuttigieg @jmckenna
related issues/PR: #398, localcontexts/localcontextshub#198, iodepo/odis-in#23