Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer export.companionFileTemplatePath if the value is given #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LucaGobbo
Copy link
Collaborator

This is how the functionality actually should work,

I want the following to also work:

  • I want the parent directories, to get the correct Contents.json file (which is driven by useXcodeAssetCompanionFile)
  • I also want to be able to use a custom companion template, which get ignored when I pass true for useXcodeAssetCompanionFile

alternatives:

    • add a new flag to the Config which indicates these Content.json files for directories need to be created
    • add a new flag that indicates we should prefer the companionFileTemplatePath over the one provided when you set useXcodeAssetCompanionFile to true

These options add more flags to the config, so I opted for the solution I provided in this PR

Copy link

Test Results

2 tests   2 ✅  18s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 479fe7e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant