Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional ignore_case param to wait_for_strings #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

summersamara
Copy link

@summersamara summersamara commented Jul 3, 2024

Motivation:

While trying to build python-redis-lock
on NixOS with redis-server version 7.2.5
the tests kept failing at wait_for_strings assertion on the output of redis-server, because the redis-server was outputting:
Ready to accept connections
instead of
ready to accept connections (different string case)

# python-redis-lock: tests/conftest.py
    with TestProcess(
        'redis-server', '--port', '0', '--save', '', '--appendonly', 'yes', '--dir', tmp_path, '--unixsocket', redis_socket
    ) as redis_server:
        wait_for_strings(redis_server.read, 2, 'ready to accept connections')

I would also create a PR in parallel to this one, in python-redis-lock repository, to make use of the change proposed in this PR in case it got approved and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant