Add optional ignore_case param to wait_for_strings #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
While trying to build python-redis-lock
on NixOS with redis-server version 7.2.5
the tests kept failing at
wait_for_strings
assertion on the output of redis-server, because the redis-server was outputting:Ready to accept connections
instead of
ready to accept connections
(different string case)I would also create a PR in parallel to this one, in python-redis-lock repository, to make use of the change proposed in this PR in case it got approved and released.