test_no_overlap2[decode_responses=False] fails #86
Comments
|
Are there some memory limits or something that may make the redis server close connections? |
|
Yes, probably, but they should be pretty high: my computer has 15 GB RAM, 700+ MB free, and there are some constraints in the build system, but those should be again in GBs of RAM. |
|
Maybe you have some file descriptor limits that create that disconnect problem? |
|
|
open files = 1024 is not really adequate, there'd be lots of fd trashing in the ton of integration tests that PRL has. |
Rising the value to 63393 doesn't seem to help too much. |
|
Well there's something weird going on. I'd need to change a bit the tests to dump out the redis logs. But you're the only one able to reproduce this problem so I must ask if this is really worth pursuing - running integration tests in a build system... |
|
On the one hand of course adding one exception to |
|
Well it's suspicious that it fails just that one test (I hope you have tried to run the tests at least a dozen times). I'm not saying it's not possible to fix (or better said, to figure out why it happens), but it'll take time. CI passed 20 days ago (https://travis-ci.org/ionelmc/python-redis-lock) so I asked if it's worth spending the time. |
|
It is probably not. Just leave this ticket open, and it can be fixed anytime. |
|
It's up to you ;-) Try this patch: diff --git a/tests/test_redis_lock.py b/tests/test_redis_lock.py
index 5d91e8e..0915543 100644
--- a/tests/test_redis_lock.py
+++ b/tests/test_redis_lock.py
@@ -364,7 +364,7 @@ NWORKERS = 125
@pytest.mark.skipif(platform.python_implementation() == 'PyPy', reason="This appears to be way too slow to run on PyPy")
-def test_no_overlap2(make_process, make_conn):
+def test_no_overlap2(make_process, make_conn, redis_server):
"""The second version of contention test, that uses multiprocessing."""
go = multiprocessing.Event()
count_lock = multiprocessing.Lock()
@@ -397,6 +397,7 @@ def test_no_overlap2(make_process, make_conn):
time.sleep(1)
+ print(redis_server.read())
assert count.value == 1
|
https://build.opensuse.org/request/show/881211 by user mcepl + RBrownSUSE - Skip test test_no_overlap2 (gh#ionelmc/python-redis-lock#86)
|
The relevant part is probably: By the way, talking about complicated and non-complicated fixes: |
|
I'm also getting this now in Archlinux. (And Nix apperently as well as can be seen above). This didn't happen when I built the package on |
|
I just upgraded the archlinux package to 4.0.0. The test in question here passed with no problems. |
When packaging this package for openSUSE/Factory I get this error:
Complete build log with all details and versions of all packages used.
The text was updated successfully, but these errors were encountered: