Rename package virtualenv to virtualenv_rewrite

[berdario]

Since I'd like to get some users to try out the rewritten virtualenv, I was thinking of adding it to a dependency of my pew. This would solve some small issues due to the old virtualenv's custom site.py

Since pew could be installed globally for the user (in ~/.local/bin)... changing virtualenv in place might lead to problems (for example, trying to uninstall virtuaenv-rewrite will leave the already created virtualenvs half-broken)

You mentioned how using the same name is probably a bad idea:

I have published that as an experiment. In retrospect I think it's a bad idea since the legacy virtualenv will still be installed if you install that. It's like a last one wins situation, and in some cases it's hard to predict which one will run.

So, maybe this PR could be acceptable? (if not on develop maybe on another branch? obviously this PR shouldn't be merged on the branch that is eventually then planned to be merged back into virtualenv master)

If accepted, I'd also like to then get a new release on PyPI

Obviously I could do all of this on my own, manage my shallow fork and keeping it updated on pypi, but I'd rather avoid having yet-another-shallow-fork on PyPI

Thank you

[ionelmc]

I'm not very sure about this idea. For now, I'd like to avoid having a competing virtualenv - I don't want to do the setuptools-distribute drama all over again - it simply ain't worth my time.

Since pew could be installed globally for the user (in ~/.local/bin)... changing virtualenv in place might lead to problems (for example, trying to uninstall virtuaenv-rewrite will leave the already created virtualenvs half-broken)

I haven't tested this but I suspect it'll just work - the created virtualenv don't have any runtime dependency on the virtualenv package or virtualenv.py

You mentioned how using the same name is probably a bad idea:

I'm publishing releases (with same dist and package name) in https://pypi.anaconda.org/ionelmc/ nowdays. Seems to work fine with --extra-index-urls.

Can you explain a bit more why upgrading virtualenv (with the releases from https://pypi.anaconda.org/ionelmc/) is a problem for you?

[berdario]

Since pew could be installed globally for the user (in ~/.local/bin)... changing virtualenv in place might lead to problems (for example, trying to uninstall virtuaenv-rewrite will leave the already created virtualenvs half-broken)

I haven't tested this but I suspect it'll just work - the created virtualenv don't have any runtime dependency on the virtualenv package or virtualenv.py

In the week after I originally opened this, I tried to reproduce the issue (unfortunately I originally opened it while I was traveling, and so I couldn't look into it again immediately after your answer), but failed (even if I think I still had that error in my scrollback).

So, I'm not confortable with not being able to reproduce the problem... but ultimately I could trust this, scrap the PR and just adopt it. Otoh, it seems that no-one else picked up interest in merging this back upstream, and since I also lack enough time+willpower to dedicate to such an effort, I think that I'll avoid adopting this rewrite for now.

(I just wanted to get this discussion to a closure, even if one that's a bit unsatisfactory )