feat(serve): support --consolelogs option #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets up a websocket server and injects a script in to the app to pass console logs back to the server to be printed in the terminal. --consolelogs-port configures the websocket server port
tlancina
added a commit
to ionic-team/ionic-cli
that referenced
this pull request
Mar 8, 2019
Anything that triggers an `ionic-cordova-serve`, as defined in `@ionic/angular-toolkit`, will pass through the --consolelogs and --consolelogs-port flags, allowing you to print app console logs to the terminal. Right now that is `ionic cordova run ios --livereload` and `ionic serve --devapp`, Addresses #3169. Depends on ionic-team/angular-toolkit#100.
tlancina
added a commit
to ionic-team/ionic-cli
that referenced
this pull request
Mar 8, 2019
Anything that triggers an `ionic-cordova-serve`, as defined in `@ionic/angular-toolkit`, will pass through the --consolelogs and --consolelogs-port flags, allowing you to print app console logs to the terminal. Right now that is `ionic cordova run ios --livereload` and `ionic serve --devapp`, Addresses #3169. Depends on ionic-team/angular-toolkit#100.
imhoffd
reviewed
Mar 8, 2019
imhoffd
reviewed
Mar 9, 2019
imhoffd
approved these changes
Mar 21, 2019
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
wand1252
added a commit
to wand1252/angular-toolkit-develop
that referenced
this pull request
Aug 31, 2022
# [1.5.0](ionic-team/angular-toolkit@v1.4.1...v1.5.0) (2019-03-21) ### Bug Fixes * **cordova:** obey `--source-map` for production builds ([23481bd](ionic-team/angular-toolkit@23481bd)) ### Features * **cordova-serve:** support --consolelogs option ([#100](ionic-team/angular-toolkit#100)) ([07af906](ionic-team/angular-toolkit@07af906))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up a websocket server and injects a script in to the app to
pass console logs back to the server to be printed in the terminal.
--consolelogs-port configures the websocket server port